Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
dash-spvproject, focusing on build process improvements, API enhancements, and code refactoring. The most significant changes involve adjustments to the build script, the introduction of new API methods withc_voidsupport, and updates to thefermentlibrary usage.Build Process Improvements:
dash-spv-apple-bindings/build.shto include additionalwaitcommands, create necessary directories, and fix a bug incbindgenusingsedcommands. This ensures smoother and more reliable builds. [1] [2] [3]API Enhancements:
u64_destroy,i32_destroy) indash-spv-apple-bindings/src/fermented_extended.rsto improve memory management.fetch_incoming_contact_requests_in_contextandfetch_outgoing_contact_requests_in_contextmethods indash-spv-platform/src/document/contact_request.rsto support fetching contact requests with context-aware logic.ContractModelstruct andContractStateenum indash-spv-platform/src/contract/model.rsto manage contract states and interactions.Code Refactoring:
std::os::raw::c_voidwithc_voidand updated related method signatures indash-spv-apple-bindings/src/lib.rsfor consistency and readability. [1] [2]dash-spv-platform/src/document/manager.rsto use a custom entropy generator instead ofDefaultEntropyGenerator, improving randomness generation.Dependency Updates:
logas a dependency indash-spv-platform/Cargo.tomland removed thefermentdependency indash-spv-masternode-processor/Cargo.tomlto streamline dependencies. [1] [2]